Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create proposal for upgrade16 to replace all priceFeed vats #9370

Open
Chris-Hibbert opened this issue May 15, 2024 · 0 comments
Open

create proposal for upgrade16 to replace all priceFeed vats #9370

Chris-Hibbert opened this issue May 15, 2024 · 0 comments
Assignees
Labels
contract-upgrade Emerynet test this in emerynet next-release about next agoric-sdk or endo release performance Performance related issues Testnet

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

#8400 reported that the priceFeed vats hold onto old quotes in their recoverySet, preventing them from being collected. #9013 made recoverySets optional. #8740 showed how to update the priceFeeds and their clients. #9283 applied the fixes to master. We have recent results showing that after these fixes, priceFeed vats and Zoe no longer grow as price updates are submitted.

image

Description of the Design

The next step is to apply the fixes from #9283 to an upcoming upgrade. (currently planned to be upgrade 16) Mainnet has different price feed vats, so the proposal will be different.

Security Considerations

N/A

Scaling Considerations

This is all about remediating a known problem on the running chain.

Test Plan

The approach has already been tested. We'll need to verify the script in a testNet, which will have yet other different priceFeeds.

Upgrade Considerations

Yes

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request performance Performance related issues Testnet contract-upgrade next-release about next agoric-sdk or endo release Emerynet test this in emerynet labels May 15, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this May 15, 2024
@Chris-Hibbert Chris-Hibbert removed the enhancement New feature or request label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade Emerynet test this in emerynet next-release about next agoric-sdk or endo release performance Performance related issues Testnet
Projects
None yet
Development

No branches or pull requests

1 participant