Skip to content

Code Review Checklist

Jump to bottom
Dan Connolly edited this page Mar 1, 2021 · 14 revisions

WIP. An initial draft based on a new team member's emerging understanding.

We delegate several checks to continuous integration tools:

  • unit testing
  • style, type annotation checking (lint)

But some aspects of house style are not automated:

  • Object Capability Discipline - minimizing, if not eliminating, ambient authority (#2160)
  • release notes; each package may use one of two styles:
  • care with interleaving points (await)

See also: code-style issue label.

Clone this wiki locally