New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngx-material-timepicker-dial display format is hardcoded #419

Open

luiz-soares opened this issue Jan 2, 2023 · 1 comment

Contributor

luiz-soares commented Jan 2, 2023 •

edited

Loading

hi,

I noticed that the format used to display the time by ngx-material-timepicker-dial is hard coded to HOUR : MINUTE PERIOD

This causes at least two differences between the value displayed in input and in the time picker:

Some locales like Finnish use . (dot) as separator instead.
Japanese periods are rendered before time

Would you accept a PR to fix at least 1 ?

You can see that in https://stackblitz.com/edit/angular-13-znkf4b

Owner

Agranom commented Jun 14, 2023

@luiz-soares Hi. Sure, you can prepare the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment