Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editable dial is not updating when user click on hour and minutes while enableKeyboardInput is true #453

Open
venkateshparihar opened this issue Aug 17, 2023 · 7 comments

Comments

@venkateshparihar
Copy link

venkateshparihar commented Aug 17, 2023

In ngx-material-timepicker demo page editable dial it working properly but when i implement in my app then editable dial is not updating Please check

proper solution: add set and get for time input on NgxMaterialTimepickerDialControlComponent. so when time changes we can update form control in setter.

Quick fix: update input by classname when the time changes .

Linked of fix:
(https://stackblitz.com/edit/angular-ivy-8dy2p2?file=package.json,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fapp.component.html,src%2Findex.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fhello.component.ts)

@ngocdu99
Copy link

ngocdu99 commented Oct 9, 2023

@venkateshparihar I encountered the same situation as you, are you waiting for the library to update to fix it or did you fix it yourself.

@Agranom Can you answer it for me?

@venkateshparihar
Copy link
Author

venkateshparihar commented Oct 9, 2023

@venkateshparihar I encountered the same situation as you, are you waiting for the library to update to fix it or did you fix it yourself.

@Agranom Can you answer it for me?
check this example may be this will be helpful for you
(https://stackblitz.com/edit/angular-ivy-8dy2p2?file=package.json,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fapp.component.html,src%2Findex.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fhello.component.ts)

@ngocdu99
Copy link

ngocdu99 commented Oct 9, 2023

@venkateshparihar Do you know what version the demo version is?
This is demo https://agranom.github.io/ngx-material-timepicker/

@venkateshparihar
Copy link
Author

@venkateshparihar Do you know what version the demo version is? This is demo https://agranom.github.io/ngx-material-timepicker/

unfortunately no

@DhruvRaiPuri
Copy link

@venkateshparihar - thanks for your workaround - it works well!

Would be better to have a fix for this in library code itself.

@arijnr
Copy link

arijnr commented Jan 2, 2024

Hi everyone, I created a PR with a fix:
#461

@pfugiel
Copy link

pfugiel commented Feb 6, 2024

@arijnr thx. When can we expect new release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants