-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editable dial is not updating when user click on hour and minutes while enableKeyboardInput is true #453
Comments
@venkateshparihar I encountered the same situation as you, are you waiting for the library to update to fix it or did you fix it yourself. @Agranom Can you answer it for me? |
|
@venkateshparihar Do you know what version the demo version is? |
unfortunately no |
@venkateshparihar - thanks for your workaround - it works well! Would be better to have a fix for this in library code itself. |
Hi everyone, I created a PR with a fix: |
@arijnr thx. When can we expect new release with this fix? |
In ngx-material-timepicker demo page editable dial it working properly but when i implement in my app then editable dial is not updating Please check
proper solution: add set and get for time input on NgxMaterialTimepickerDialControlComponent. so when time changes we can update form control in setter.
Quick fix: update input by classname when the time changes .
Linked of fix:
(https://stackblitz.com/edit/angular-ivy-8dy2p2?file=package.json,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fapp.component.html,src%2Findex.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fhello.component.ts)
The text was updated successfully, but these errors were encountered: