Use Active Storage for Picture and File attachments #2544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
active-storage
branch
2 times, most recently
from
7fc3de3 to
9e46ec4
Compare
10 tasks
|
This pull request has not seen any activiy in a long time. |
tvdeyen
force-pushed
the
active-storage
branch
from
e6bcf92 to
fe22999
Compare
Necessary for active storage image transforms
ActiveStorage uses the image_processing gem to process images. This uses a hash to describe the conversion instead of a string
Instead of using the Dragonfly Model validations we write our own. That way we can use another image attachment library more easily
The vips image_processing processor sharpens images by default. This disables this behavior.
Active storage already knows if a file is convertible
This avoids N+1 in the image library
Using activestorage methods to read the values. Ideally we would cache these values, but active storage asynchronously sets these values and provides no callback we could use.
Now that we use ActiveStorage we can remove our custom picture variant handling
This method is the only one left after the PictureVariant and PictureThumb removal.
Active storage has the mime type stored not the extension.
ruby-vips and mini_magick need to be told to ignore the page in order to resize animated gifs.
Before we where not telling active storage that we want a certain format explicitely. We need that for displaying animated PNGs properly.
Proxy downloads the file.
Rails only adds it in Rails 7.1
tvdeyen
force-pushed
the
active-storage
branch
from
8e7b45e to
6fd573d
Compare
Only works in Rails 7.1
tvdeyen
force-pushed
the
active-storage
branch
from
6fd573d to
6b5b532
Compare
tvdeyen
force-pushed
the
main
branch
3 times, most recently
from
4ea5c7d to
19e4094
Compare
|
This pull request has not seen any activiy in a long time. |
|
This pull request has not seen any activiy in a long time. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Reworks #2288
Use ActiveStorage instead of Dragonfly for picture and file attachments.
Important changes
vips. It works withmini_magickthoughTODO
Alchemy::Attachmentas wellmini_magickuse proxy instead of redirectChecklist