Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify module controllers at runtime #3093

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 21, 2024

Prior to this commit, we were doing this at load time, accidentally loading all controllers linked to in the menu.

Prior to this commit, we were doing this at load time, accidentally
loading all controllers linked to in the menu.
@mamhoff mamhoff requested a review from a team as a code owner November 21, 2024 16:22
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (c8c85f9) to head (6f3007f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3093      +/-   ##
==========================================
- Coverage   96.59%   96.58%   -0.01%     
==========================================
  Files         236      236              
  Lines        6337     6334       -3     
==========================================
- Hits         6121     6118       -3     
  Misses        216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdeyen tvdeyen merged commit c755127 into AlchemyCMS:main Nov 21, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants