Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Updated analysis: TCGA TMB BED files update v16 #668

Closed
cansavvy opened this issue Apr 2, 2020 · 6 comments
Closed

Updated analysis: TCGA TMB BED files update v16 #668

cansavvy opened this issue Apr 2, 2020 · 6 comments
Labels
snv Related to or requires SNV data updated analysis

Comments

@cansavvy
Copy link
Collaborator

cansavvy commented Apr 2, 2020

What analysis module should be updated and why?

snv-callers
TCGA TMB calculations need to be updated now that we have a new set of BED files that more accurately show the target regions.

What changes need to be made? Please provide enough detail for another participant to make the update.

Now that BED files are not just assigned by WGS or WXS sample designations, we need to make a way to supply a BED files to sample ID key so we know which sample's TMB should be calculated with which target region BED file.

What input data should be used? Which data were used in the version being updated?

v16 data

When do you expect the revised analysis will be completed?

This week.

Who will complete the updated analysis?

@cansavvy

@cansavvy cansavvy added updated analysis snv Related to or requires SNV data labels Apr 2, 2020
@cansavvy
Copy link
Collaborator Author

cansavvy commented Apr 3, 2020

I'll be working on setting this up today. I think my plan for this issue is to add an option to the 03-calculate_tmb.R script and calculate_tmb function that allows you to pass in a column of the BED file names that correspond to each biospecimen IDs.

Currently, its set up to use BED files based on whether a sample is WGS or WXS. The question is do I switch everything to the column strategy? Or do I add the "provide a column strategy" while maintaining the specify BED files for all WGS and all WXS strategy?

@jashapiro
Copy link
Member

I would switch to providing a table of sample/bed pairs. I don't think maintaining four different options is worthwhile.

@jaclyn-taroni
Copy link
Member

Just wanted to note that some of the changes in c9675fd and 94e6e25 need to be undone when this gets addressed.

@cansavvy
Copy link
Collaborator Author

The BED files for TCGA have been updated and the analysis re-run completely. The TMB values for TCGA are slightly higher, and now we have some outliers show up, but it's still not able to overcome the inherent WGS vs WXS difference we have confounding our PBTA vs TCGA comparison.
Updated:
tmb-cdf-pbta-tcga

Old version for comparison:
old-tmb-cdf-pbta-tcga

@jaclyn-taroni
Copy link
Member

@cansavvy was this closed by #671?

@cansavvy
Copy link
Collaborator Author

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
snv Related to or requires SNV data updated analysis
Projects
None yet
Development

No branches or pull requests

3 participants