Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cluster column name #484

Closed
sjspielman opened this issue Oct 3, 2023 · 1 comment
Closed

Change cluster column name #484

sjspielman opened this issue Oct 3, 2023 · 1 comment

Comments

@sjspielman
Copy link
Member

Currently we are naming the cluster column clusters:

scpca-nf/bin/cluster_sce.R

Line 88 in fb5f3bf

sce$clusters <- clusters

In #483 (comment), @jashapiro pointed out that this may imply existence of multiple clusters per cell, which ain't it.

It should be $cluster unless we are assigning one cell to multiple clusters.

So, let's rename change to cluster; this will involve some QC report changes as well.
This was referenced Oct 3, 2023
Merged
Merged
@sjspielman
Copy link
Member Author

Closed by #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjspielman