Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD/HD toggle #523

Closed
dbuezas opened this issue Jul 11, 2023 · 11 comments · Fixed by #525
Closed

SD/HD toggle #523

dbuezas opened this issue Jul 11, 2023 · 11 comments · Fixed by #525
Labels
enhancement New feature or request
Milestone

Comments

@dbuezas
Copy link
Contributor

dbuezas commented Jul 11, 2023

When on the go I often miss the option to switch to a lower resolution stream.
I intend to work on a PR that adds a config option url_sd. When present, the UI will add a new button that will toggle between SD and HD and switch between the streams.

What do you think?

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

I don't think it should be url_sd.

I think it should be list of URLs and modes. User can click on mode label for switch to next item. Or some drop down should appear.
When new url+mode selected - card should restart connection process.

This realisation will close many cases.

@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 11, 2023

Something like this?

streams:
  - url: rtsp://high-res
    name: hd
  - url: rtsp://low-res
    name: sd

or

urls:
  hd: rtsp...
  sd: rtsp...
  other: rtsp...

?

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

Yes. And mode: webrtc... may be useful.
Better first version with list. Because order also important.

@direx1
Copy link

direx1 commented Jul 21, 2023

I don't think it should be url_sd.

I think it should be list of URLs and modes. User can click on mode label for switch to next item. Or some drop down should appear. When new url+mode selected - card should restart connection process.

This realisation will close many cases.

This and the example below your comment would be really useful. Currently I use a shortcut button to run a browser_mod popup with a high res stream but this would perhaps be better.

@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 21, 2023

The linked PR implements this, it will probably land in master sooner or later :)

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 21, 2023

I correct myself: "later rather than sooner" 😆

@AlexxIT
Copy link
Owner

AlexxIT commented Aug 21, 2023

Oh, sorry. Was on holidays two weeks.

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 21, 2023

Hehe, I'm joking! :)

@AlexxIT AlexxIT added this to the v3.3.0 milestone Aug 24, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Aug 24, 2023

@marcob79
Copy link

I try this new interesting function, but it is not clear how to do the switch :)
I dind't see also the name assigned to the 2 url

type: custom:webrtc-camera
streams:
  - url: camera.go_box
    name: HD
  - url: camera.go_sala
    muted: true
    name: SD

@AlexxIT
Copy link
Owner

AlexxIT commented Aug 25, 2023

Name shown when ui enabled. Switch on click on mode label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants