Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC DashCast not working with HA 2024.3.0 and Chromecast/pycast #664

Closed
Cheerpipe opened this issue Mar 7, 2024 · 6 comments · Fixed by #665
Closed

WebRTC DashCast not working with HA 2024.3.0 and Chromecast/pycast #664

Cheerpipe opened this issue Mar 7, 2024 · 6 comments · Fixed by #665
Assignees
Labels
bug Something isn't working

Comments

@Cheerpipe
Copy link
Contributor

DashCast works OK with HA 2024.2.x but it stopped working with latest update.

Logger: custom_components.webrtc.utils
Source: custom_components/webrtc/utils.py:191
Integration: WebRTC Camera ([documentation](https://github.com/AlexxIT/WebRTC), [issues](https://github.com/AlexxIT/WebRTC/issues))
First occurred: 10:00:50 (1 occurrences)
Last logged: 10:00:50
Can't DashCast to ['media_player.nest_dormitorio']


Traceback (most recent call last):
  File "/config/custom_components/webrtc/utils.py", line 191, in dash_cast
    entity.dashcast.load_url(url, force)
TypeError: DashCastController.load_url() takes 2 positional arguments but 3 were given

Example service call:

service: webrtc.dash_cast
data:
  entity_id: media_player.nest_dormitorio
  entity: camera.frigate_dormitorio_pequeno
  force: true
  • Tried with entity and with URL as source with same results.
  • Tried with Force enabled and disabled, true and false with same results.
  • Screen is Google Nest Hub.
@Cheerpipe
Copy link
Contributor Author

I am not a python guy but seems load_url function signatura has changed

image

@Cheerpipe Cheerpipe changed the title WebRTC DashCast not working with HA 2024.3.0 WebRTC DashCast not working with HA 2024.3.0 and Chromecast/pycast Mar 7, 2024
@Cheerpipe
Copy link
Contributor Author

Changing line 191 to this seems to do the trick

entity.dashcast.load_url(url, force = force)

Juast added the 'force ='

Won't PR becase don't know if it is the correct way to fix this but hope this helps.

@AlexxIT
Copy link
Owner

AlexxIT commented Mar 7, 2024

@Cheerpipe this is correct way

@NHMikeG
Copy link

NHMikeG commented Mar 27, 2024

Hi - I opened up an issue in Home Assistant for this same issue (home-assistant/core#114310), before I did digging around and found this issue raised within WebRTC.

Sorry if this is a stupid question because I see this is Closed...will this be fixed with a future WebRTC component release?

@NHMikeG
Copy link

NHMikeG commented Mar 27, 2024

disregard, I figured it out by manually modifying the utils.py!

@AlexxIT
Copy link
Owner

AlexxIT commented Apr 7, 2024

@AlexxIT AlexxIT added the bug Something isn't working label Apr 7, 2024
@AlexxIT AlexxIT self-assigned this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants