Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an Alias table to Decapode ACSet Schema #155

Closed
jpfairbanks opened this issue Oct 25, 2023 · 4 comments
Closed

Adding an Alias table to Decapode ACSet Schema #155

jpfairbanks opened this issue Oct 25, 2023 · 4 comments

Comments

@jpfairbanks
Copy link
Member

When you have a decapode with equations like this:

dexp = parse_decapode(quote
  A::Form0{X}
  B::Form1{X}
  C::Form0{X}
  D::Form0{X}

  B == grad(A)
  C == f(A,B)
  ∂ₜ(A) == C
  ∂ₜ(D) == C + D
end)

Our current code will eliminate the variable C and by renaming it to A\dot. We probably need another table of aliases that is just a binary relation on Var for tracking equations between variables.

@olynch, does the GATLab approach solve this problem in a more general way?

@lukem12345
Copy link
Member

Did we not fix this in #136 ?

Not at a REPL now, so I cannot check this.

@lukem12345
Copy link
Member

This is the test I am referring to:

@test pt5[:name] == [:X, :V, :k, :mult_1, Symbol('V'*'\U0307'), Symbol("-1")]

@jpfairbanks
Copy link
Member Author

I ran into this problem when building the DecaExpr outside of parse_decapode or @decapode. There might be something about how I am generating the DecaExpr.

@lukem12345
Copy link
Member

I see. I will check in the morning on where dot_rename! may be erroneously getting called.

@lukem12345 lukem12345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants