Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Inline JS support to ESlint #529

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added Inline JS support to ESlint #529

wants to merge 2 commits into from

Conversation

subhangi2731
Copy link
Contributor

Description

added Inline JS support to ESlint

Fixes #518

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@subhangi2731
Copy link
Contributor Author

@harikesh409 @ravikr126 please merge my pr I have done

harikesh409
harikesh409 requested changes May 30, 2021
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated linting is not done properly do the required changes.

README.md Outdated Show resolved Hide resolved
js/index.js Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
DSA.html Outdated Show resolved Hide resolved
booklist.html Outdated Show resolved Hide resolved
ide.html Outdated Show resolved Hide resolved
@subhangi2731
Copy link
Contributor Author

@harikesh409 I will do the changes bu tomorrow will I get scores for this and can u merge as I send the pr before may 31??

@subhangi2731
Copy link
Contributor Author

@harikesh409 @ravikr126 I have done all the changes as told by u and have rectified everything please merge my pr by tomorrow

@harikesh409
Copy link
Collaborator

harikesh409 commented Jun 4, 2021 •
edited
Loading

Resolve merge conflicts and also a blank line addition is present on readme file remove that also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikesh409 harikesh409 harikesh409 requested changes

Assignees

@subhangi2731 subhangi2731

Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To add inline JS support to eslint
2 participants
@subhangi2731 @harikesh409