Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code now supports more protocols #11

Closed
flying-sheep opened this issue May 6, 2024 · 5 comments
Closed

VS Code now supports more protocols #11

flying-sheep opened this issue May 6, 2024 · 5 comments

Comments

@flying-sheep
Copy link

By default, that’s now

[
	'file',
	'http', 'https',
	'mailto',
	'vscode', 'vscode-insiders',
]

And it’s customizable. That makes OSC 8 usable in the VS Code terminal.

See microsoft/vscode#176812

@Alhadis
Copy link
Owner

Alhadis commented May 7, 2024

@flying-sheep I'm not sure how (or if) this should be integrated into the list. From my reading of vscode#176812, it would appear that VS Code did support OSC 8, but it hitherto only recognised URLs that used http or https protocols. That still technically qualifies as "supporting OSC 8 escape sequences".

@flying-sheep
Copy link
Author

I don’t think it’s in the list yet, so I’d say now is a good time to add it.

@Alhadis
Copy link
Owner

Alhadis commented May 7, 2024

@flying-sheep Do you know when VS Code first introduced support for OSC 8 hyperlinks? (Configurable or not).

@AnonymouX47
Copy link

For what it's worth, I thought I should note that VS Code embeds xterm.js (which is already listed) for its terminal. Hence, I would expect it (VS Code Terminal) to be listed underneath xterm.js, just like with the VTE-based emulators.

As for when Hyperlinks support was added, see here and for extra info:

@Alhadis Alhadis closed this as completed in aebbeab Sep 6, 2024
@Alhadis
Copy link
Owner

Alhadis commented Sep 6, 2024

Alright, added. I'm unsure how else to proceed regarding protocols, so I'm simply honouring the precedent set in jamestalmage/supports-hyperlinks#17 by treating VS Code v1.72.0 as when hyperlink support was "officially" introduced. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants