Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return UINavigationController when applicable #40

Closed
gsimmons opened this issue Oct 23, 2015 · 2 comments
Closed

Return UINavigationController when applicable #40

gsimmons opened this issue Oct 23, 2015 · 2 comments
Labels
type: enhancement

Comments

@gsimmons
Copy link

It would be very helpful if the return type for any UINavigationControllers was UINavigationController instead of UIViewController.
@AliSoftware
Copy link
Collaborator

Agreed.

I think this will already be fixed once #24 is merged, via the change in this commit: now I use the XML tag and prepend UI to it, so when the XML tag in the XIB is <navigationController …> or <tableViewController …> I'll generate UINavigationController or UITableViewController.

Would need to retest once this PR for #24 is finished and merged.

AliSoftware added a commit that referenced this issue Oct 25, 2015
@AliSoftware
Improved fixtures to ensure #40 is indeed fixed
0f66daf
@AliSoftware
Copy link
Collaborator

Now that #24 is merged, this is now fixed in master, and Unit Tests now ensure it stays fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsimmons @AliSoftware