Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect color parsing #28

Merged
merged 2 commits into from
Oct 5, 2015
Merged

Fix incorrect color parsing #28

merged 2 commits into from
Oct 5, 2015

Conversation

Igor-Palaguta
Copy link
Contributor

Fix parsing value, that starts with 0x and alpha is absent

@Igor-Palaguta
Fix tool name in documentation
9004816 
Fix parsing value, that starts with 0x and alpha is absent
@Igor-Palaguta Igor-Palaguta mentioned this pull request Oct 5, 2015
Closed
@AliSoftware
Copy link
Collaborator

LGTM 👍

Could you please:

  • add such a case in the test fixtures (having a 0x123456 color in the colors.txt for example), to ensure this use case is covered and there won't be any regression in the future about this
  • add an entry in the CHANGELOG to credit yourself

Thx!

@AliSoftware AliSoftware mentioned this pull request Oct 5, 2015
Closed
@Igor-Palaguta
Copy link
Contributor Author

Please check commit

@AliSoftware AliSoftware merged commit c6729f8 into SwiftGen:master Oct 5, 2015
@AliSoftware
Copy link
Collaborator

Perfect 👌 thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Igor-Palaguta @AliSoftware