Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludechars #34

Merged
merged 2 commits into from
Oct 17, 2015
Merged

Excludechars #34

merged 2 commits into from
Oct 17, 2015

Conversation

Igor-Palaguta
Copy link
Contributor

Added excludechars argument to image, string, storyboard command

@AliSoftware
Copy link
Collaborator

LGTM from the GitHub diff, will have to test in Xcode once I'm home.
Any idea why the tests fails on Travis? Did they pass locally in your Xcode?

@Igor-Palaguta
Copy link
Contributor Author

On my machine all tests passed, do you have expected and result values for failed tests?

@AliSoftware
Copy link
Collaborator

Well I only see the same as what you can see in Travis CI, sot sure why it fails yet.

@AliSoftware
Copy link
Collaborator

On my machine all tests passed

I can't see how that was possible: on my machine they don't pass (in fact they crash), because it seem you forgot to add the new expected files (*.swift.out) to the Xodeproj (so it fails to load the fixture to compare the result with the expected fixture).

Are you sure you did run the test using the swiftgen-cli scheme? Maybe there was another scheme selected by default and you didn't actually run the test you thought?

Anyway, I'm adding them myself right now, so don't bother, I'll do it when merging ;-)

@AliSoftware AliSoftware merged commit 2db1298 into SwiftGen:master Oct 17, 2015
AliSoftware added a commit that referenced this pull request Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants