Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos: 'instanciate' -> 'instantiate' #83

Merged
merged 5 commits into from
Jan 15, 2016

Conversation

pankolega
Copy link

'nuff said :)

@darecki
Copy link

darecki commented Jan 15, 2016

Great idea! That typo was bothering me very much.

@AliSoftware
Copy link
Collaborator

Damn, that's one of those words I'll misspell every time due to the different spelling of the same word in French 😆 Well spotted, sir, thx!

@AliSoftware
Copy link
Collaborator

Could you just maybe add an entry in the CHANGELOG.md to credit yourself and make note that the storyboards-default template changed?

It may seem like a very little change, but every change deserve attribution, and as a lot of people probably use the default template this will change their generated code and will have to adapt their codebase, so it's worth mentioning anyway imho.

@pankolega
Copy link
Author

Sure thing. It is definitely a breaking change.

@AliSoftware
Copy link
Collaborator

Sorry I should have been more explicit: version 0.7.5 is already released to Homebrew, without that change. So the entry in the changelog should be in a new ## Master entry, ready for the next release
(which will probably be 0.7.6, but we don't know yet, as I might wait for some other issues to be fixed before releasing a new version and those new issues might deserve a 0.8.0, idk yet)

@pankolega
Copy link
Author

That's right. I didn't want to do that without your explicit instruction.

AliSoftware added a commit that referenced this pull request Jan 15, 2016
Fixed typos: 'instanciate' -> 'instantiate'
@AliSoftware AliSoftware merged commit d276a7c into SwiftGen:master Jan 15, 2016
@AliSoftware
Copy link
Collaborator

Perfect 👌 thx for your contribution @pankolega !

@phatblat
Copy link
Member

Yay! Was just about to create a PR for this. English is weird. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants