Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recommend] Do not delete BT tasks automatically after the offline download is complete! #3588

Closed
4 tasks done
m0ch3 opened this issue Feb 24, 2023 · 1 comment
Closed
4 tasks done
Labels
enhancement New feature or request

Comments

@m0ch3
Copy link

m0ch3 commented Feb 24, 2023

Please make sure of the following things

  • I have read the documentation.
  • I'm sure there are no duplicate issues or discussions.
  • I'm sure this feature is not implemented.
  • I'm sure it's a reasonable and popular requirement.

Description of the feature / 需求描述

Recommended that DO NOT make it the default behavior to automatically delete BT tasks after the offline download is complete, that's blood-sucking.

Suggested solution / 实现思路

An optional configuration or a button could be added to allow users to decide whether to automatically delete.

Additional context / 附件

Source code in v3.12.0 internal\qbittorrent\monitor.go from line 115 - 120:

// delete qbittorrent task but do not delete the files before transferring to avoid qbittorrent
// accessing downloaded files and throw `cannot access the file because it is being used by another process` error
err = qbclient.Delete(m.tsk.ID, false)
if err != nil {
    return err
}

After the qBittorrent download task is completed, no exclusive lock will be added to the file, but a read shared lock. Seems that it does not affect the the file reading, such as in Python: open("filePath","rb"), or in Golang: os.OpenFile(filePath, os.O_WRONLY|os.O_RDONLY, 0).

@m0ch3 m0ch3 added the enhancement New feature or request label Feb 24, 2023
@welcome
Copy link

welcome bot commented Feb 24, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant