feat(s3): using internal download method in proxy #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mmx233
changed the title
xhofe
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS S3 presigned URL is not available in all AWS regions. This PR allows the S3 driver to directly execute GetObject requests instead of using presigned URLs when settings like web proxy and WebDav native proxy are enabled.
CAUTION: This PR makes the S3 driver call
common.ShouldProxyin internal methods. Passing a argument intomodel.LinkArgsorcontext.Contextmaybe a better solution. Please let me know if I should join this kind of modification.Test Docker Image:
mmx233/alist:v3.36.0-alpha3mmx233/alist:v3.36.0-alpha3-ffmpeg