Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] If the mount destination is not empty, we should see all the content after mounting #1739

Closed
YaoZengzeng opened this issue Jul 16, 2018 · 1 comment · Fixed by #1745
Assignees
Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer priority/P1 this is high priority that all maintainers should stop to handle this issue

Comments

@YaoZengzeng
Copy link
Contributor

Ⅰ. Issue Description

The Docker file of image quay.io/calico/cni:v3.1.3 is :

FROM busybox

LABEL maintainer "Tom Denham <tom@tigera.io>"

ADD dist/amd64/calico /opt/cni/bin/calico
ADD dist/amd64/flannel /opt/cni/bin/flannel
ADD dist/amd64/loopback /opt/cni/bin/loopback
ADD dist/amd64/host-local /opt/cni/bin/host-local
ADD dist/amd64/portmap /opt/cni/bin/portmap
ADD dist/amd64/calico-ipam /opt/cni/bin/calico-ipam
ADD k8s-install/scripts/install-cni.sh /install-cni.sh
ADD k8s-install/scripts/calico.conf.default /calico.conf.tmp

ENV PATH=$PATH:/opt/cni/bin
VOLUME /opt/cni
WORKDIR /opt/cni/bin
CMD ["/opt/cni/bin/calico"]

The result of running this image with Pouch and Docker is different:

[root@cal pouch]# docker run -it -v /opt/cni/bin quay.io/calico/cni:v3.1.3 sh
/opt/cni/bin # ls
calico       calico-ipam  flannel      host-local   loopback     portmap
[root@cal pouch]# pouch run -it -v /opt/cni/bin quay.io/calico/cni:v3.1.3 sh
/opt/cni/bin # ls
/opt/cni/bin # 

The reason of the difference is that the volume destination of /opt/cni is not empty, it has subdirectory cni in it.

After mounting, Docker will copy the subdirectory cni to the mount destination and Pouch has not supported this feature, we should implement this ASAP.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added kind/feature kind/feature-request This is a feature request from community for PouchContainer labels Jul 16, 2018
@YaoZengzeng YaoZengzeng added the priority/P1 this is high priority that all maintainers should stop to handle this issue label Jul 16, 2018
@pouchrobot
Copy link
Collaborator

Thanks for your report, @YaoZengzeng
😱 This is a priority/P1 issue which is highest.
Seems to be severe enough.
ping @alibaba/pouch , PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer priority/P1 this is high priority that all maintainers should stop to handle this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants