From bf0df3c4ce34bd7ca84f32a437289897517fbd34 Mon Sep 17 00:00:00 2001
From: whisper_ <vincentleelwx@gmail.com>
Date: Tue, 24 Jul 2018 10:21:11 +0800
Subject: [PATCH] test: add unit-test for getConflictConfigurations

Signed-off-by: whisper_ <vincentleelwx@gmail.com>
---
 daemon/config/config_test.go | 49 +++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/daemon/config/config_test.go b/daemon/config/config_test.go
index ecaa6389a..779f0720a 100644
--- a/daemon/config/config_test.go
+++ b/daemon/config/config_test.go
@@ -3,6 +3,7 @@ package config
 import (
 	"testing"
 
+	"github.com/spf13/pflag"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -49,7 +50,53 @@ func TestConfigValidate(t *testing.T) {
 }
 
 func TestGetConflictConfigurations(t *testing.T) {
-	// TODO
+
+	assert := assert.New(t)
+
+	flagSet := new(pflag.FlagSet)
+	flagSet.String("normal", "", "normal flag")
+	flagSet.Set("normal", "normal")
+
+	flagSet.Bool("conflict", false, "conflict flag")
+	flagSet.Set("conflict", "true")
+
+	flagSet.String("notSet", "notSet", "flag not set")
+
+	flagSet.IntSlice("intSlice", []int{1, 2, 3}, "skip int slice")
+	flagSet.Set("intSlice", "[1,2,3]")
+
+	noConflictFlagMap := map[string]interface{}{
+		"a": "a",
+		"b": "b",
+		"c": "c",
+	}
+
+	conflictFlagMap := map[string]interface{}{
+		"a":        "a",
+		"conflict": false,
+	}
+
+	skipUnsetFlagMap := map[string]interface{}{
+		"a":      "a",
+		"notSet": "notSet",
+	}
+
+	skipSliceFlagMap := map[string]interface{}{
+		"a":        100,
+		"intSlice": []int{1, 2, 3},
+	}
+
+	error := getConflictConfigurations(flagSet, noConflictFlagMap)
+	assert.Equal(error, nil)
+
+	error = getConflictConfigurations(flagSet, conflictFlagMap)
+	assert.NotNil(error)
+
+	error = getConflictConfigurations(flagSet, skipUnsetFlagMap)
+	assert.Equal(error, nil)
+
+	error = getConflictConfigurations(flagSet, skipSliceFlagMap)
+	assert.Equal(error, nil)
 }
 
 func TestGetUnknownFlags(t *testing.T) {