Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken NAV on /get-almalinux page #318

Open
codyro opened this issue Aug 28, 2023 · 7 comments
Open

Broken NAV on /get-almalinux page #318

codyro opened this issue Aug 28, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@codyro
Copy link
Member

codyro commented Aug 28, 2023

#254 introduced a new page, https://almalinux.org/get-almalinux/. On this page, a NAV appears to be broken and behaves "wonkily". See the attached video for reference:

nav-go-woooo.mov
@bennyvasquez
Copy link
Member

ah! Looks like a second click on a heading results in the content disappearing. Does that sound right?

@codyro
Copy link
Member Author

codyro commented Aug 28, 2023

Yes, also the last two items (IBM Z/Power LE) seem to have some image padding issues as they're displaying the same images when you click them, but the images display differently. Click them back and forth (or it's near the end of the video) to see what I mean.

@bennyvasquez
Copy link
Member

@sboldyreva fixed the images problem in #321, and will take a look at the rest.

In talking with her it seems the double-clicking is working as intended. It's like a dropdown menu, so the "menu" collapses on second click. I think, from an end user perspective, this isn't how I would expect this content to work. I see two potential fixes:

  1. disable the collapsing of the data on a second click
  2. add a small arrow next to the menu item as an indicator of expanded or collapsed information.

The first option is my preference, but the second can be a short-term fix if 1 is unattainable in short order.

@sboldyreva
Copy link
Collaborator

@codyro @bennyvasquez Yes, I confirm this. And I agree, we might want to disable collapsing, to keep the content open.

@sboldyreva
Copy link
Collaborator

As for the icon images (s390x and ppc64le) they should be displayed the same after the fix.

@codyro
Copy link
Member Author

codyro commented Aug 31, 2023

I think disabling collapsing would make sense from a UX perspective.

@bennyvasquez
Copy link
Member

Assigning this to you, @sboldyreva, but only so that my brain stops bothering me about it. Let me know if you need an assist here!

@bennyvasquez bennyvasquez added the bug Something isn't working label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants