Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XF86VidModeModeInfo is missing hskew #19

Closed
tomaka opened this issue Jun 26, 2015 · 6 comments
Closed

XF86VidModeModeInfo is missing hskew #19

tomaka opened this issue Jun 26, 2015 · 6 comments

Comments

@tomaka
Copy link

tomaka commented Jun 26, 2015

I was investigating why vdisplay was always 0 on my system.
In turns out that this library has an additional hskew field that I can't find anywhere in any reference. This seems wrong.
@tomaka
Copy link
Author

tomaka commented Jun 26, 2015

Wait. The version of x11-rs used by glutin doesn't have that field even though it is in the source code.
It's the inverse. My system does have hskew but the bindings don't.

@tomaka
Copy link
Author

tomaka commented Jun 26, 2015

Ignore my previous comment. Glutin's code mixed up XF86VidModeModeInfo and XF86VidModeModeLine.
However the hskew field is absent from XF86VidModeModeLine for what I've found on the web. I don't know whether it's a mistake.

@tomaka
Copy link
Author

tomaka commented Jun 26, 2015

Okay the reason why glutin was messing up Info and Line is because XF86VidModeGetAllModeLines takes a Info instead of a Line, which seems wrong.

@tomaka
Copy link
Author

tomaka commented Jun 26, 2015

Let me start again. Ignore everything above.

@tomaka tomaka closed this as completed Jun 26, 2015
@tomaka tomaka reopened this Jun 26, 2015
@tomaka
Copy link
Author

tomaka commented Jun 26, 2015

The XF86VidModeModeInfo struct is missing the hskew field.
I think that the documentation found of the web is wrong, since I have this field in my own headers.

@tomaka tomaka changed the title XF86VidModeModeLine looks wrong XF86VidModeModeInfo is missing hskew Jun 26, 2015
ghost referenced this issue Jul 2, 2015
@daggerbot
Add XF86VidModeInfo.hskew.
c64a861
@ghost
Copy link

ghost commented Jul 2, 2015

Fixed in 9010bec

@ghost ghost closed this as completed Jul 2, 2015
@Aatch Aatch mentioned this issue Sep 1, 2015
Closed
@ghost ghost mentioned this issue Oct 26, 2015
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka