Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make dbt ls to be configured not to be done automaticaly? #38

Closed
jesse23 opened this issue Jan 6, 2021 · 7 comments
Closed

Can we make dbt ls to be configured not to be done automaticaly? #38

jesse23 opened this issue Jan 6, 2021 · 7 comments

Comments

@jesse23
Copy link

jesse23 commented Jan 6, 2021

Hi,

Looks latest upgrade creates a dependency on python extension? It is causing several 'regressions' on my setup:

  • my dbt installation is done by homebrew which is not using default python, without switching python context it complains no dbt installatoin in curent python.

  • A complain on toolbar your dbt is not up to date. In my use case for I am still on 0.18

  • Any minor change to sql file will cause a long time list model operation....the rerun cannot start before that is done. Every change-validation cycle takes around 5 mins...

  • All the logs goes to dbt output ( I guess that is an improvement ? ), Looks cool but if I have multiple run it is hard to identify the log without syntax highlight ( which is in terminal print ). Also new terminal provides more flexibility.

@jesse23
Copy link
Author

jesse23 commented Jan 6, 2021

But in general it is a very nice plugin - I can stay focusing on my editor for project work. Thanks for the effort!

@mdesmet
Copy link
Contributor

mdesmet commented Jan 6, 2021

Hi Jesse,

Thanks for your remarks!

The first and second point I would rather consider features. There will be a lot of improvements coming where we need to be able to run DBT/Python code. Note that we don't require the user to update, but just mention that there is a newer version available.

The third one we just fixed a bug for. We had coded a debounce that ensures the list is not triggered multiple times if a file is changed but that was not working as expected. Can you verify that you are on v0.4.2? If that doesn't fix the issue I would like to know how long a dbt ls takes.

I agree on the output for the runs, they should actually use a pseudo terminal instead of the output channel which doesn't support colors. See microsoft/vscode#571. I gave the terminal a quick try just before the release but that gave other display issues. We can probably fix that soon.

@jesse23
Copy link
Author

jesse23 commented Jan 6, 2021

Thanks!

  • I just down grade from 0.4.2 to 0.3.6 ( means my former description is based on 0.4.2 ) - can we provide an option to disable it or manual refresh it?
    • Yes the dbt ls at my local takes 2 minutes.

@mdesmet
Copy link
Contributor

mdesmet commented Jan 7, 2021

dbt list should be really fast, it just looks at all your refs and regenerate the model graph. How many models are there in your project?

We can indeed make this configurable to not automatically execute dbt list on source file change.

@jesse23
Copy link
Author

jesse23 commented Jan 7, 2021

Thanks! Configurable will definitely help. Yes no doubt that my project is complex.

@jesse23 jesse23 changed the title list model takes lot of time in latest version Can we make dbt ls to be configured not to be done automaticaly? Jan 7, 2021
@mdesmet
Copy link
Contributor

mdesmet commented Jan 22, 2021

Hi Jesse,

I will release a new version shortly with following flag to disable the automatic listing.

image

@jesse23
Copy link
Author

jesse23 commented Jan 23, 2021

Works fine. Also I can see the output has been in a terminal as Tasks -dbt. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants