New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListSelector has workaround for Patternfly bug #136

Open

ghjm opened this issue Jan 21, 2022 · 0 comments

Contributor

ghjm commented Jan 21, 2022 •

edited

Loading

The ListSelector has a workaround here: https://github.com/Altinity/altinity-dashboard/blob/main/ui/src/app/Components/ListSelector.tsx#L17 for a bug in Patternfly where the ContextSelector does not open on first click when menuAppend is set to document.body, tracked here: patternfly/patternfly-react#6824. After the upstream issue closes, we should remove the workaround.

As an alternative, we could implement ListSelector using composable menu components instead of the all-in-one ContextSelector, as documented here: https://www.patternfly.org/v4/demos/composable-menu/#context-selector-using-menu-components

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment