0.17.0 Config excludeFromPropagationAnnotations not excluding annotations for various created resources

[tanenbaum]

If I set up a CHOP with config.yaml containing:

excludeFromPropagationAnnotations: ["foo"]

and a CHI with metadata like:

metadata:
  annotations:
    foo: bar

I would expect all created resources to be without the "foo" annotation.

I actually find that the StatefulSets, ConfigMaps, PVCs and host specific Services have the annotation.

Tracing through the code, I think

clickhouse-operator/pkg/model/annotator.go

Line 112 in dc6cdc6

func (a *Annotator) getHostScope(host *chiv1.ChiHost) map[string]string {

is where the problem lies.

func (a *Annotator) getHostScope(host *chiv1.ChiHost) map[string]string {
	return a.appendCHIProvidedTo(host.GetAnnotations())
}

Any function using getHostScope ends up with all the CHI annotations as a.appendCHIProvidedTo(host.GetAnnotations()) is passing in the CHI annotations that take precedence over any of the exclusions. Other similar functions here use a.appendCHIProvidedTo(nil) instead.

Perhaps (a *Annotator) appendCHIProvidedTo(dst map[string]string) should not take an argument here, as there are no defaults used as there are with labels and therefore should always be nil.

[sunsingerus]

This issue was addressed in 0.18.2 version, please check

[tanenbaum]

I will be testing this change soon (next day or so). I'll get back to you asap.

…

On Thu, 3 Feb 2022 at 16:23, Vladislav Klimenko ***@***.***> wrote: This issue was addressed in 0.18.2 version, please check — Reply to this email directly, view it on GitHub <#859 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYUAGATYWCR5NQ6PGI6Z3DUZKTZ5ANCNFSM5LV7VPAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[alex-zaitsev]

Fixed in https://github.com/Altinity/clickhouse-operator/releases/tag/0.18.2