fix non pointer mistake in metrics-exporter

[adu-bricks]

Signed-off-by: Anthony Dubuissez a.dubuissez@bricks-co.com

Fixing the metrics-exporter report of the system.parts fetch that would never return any data due to a missing pointer.

I put the master branch for this pr as I didnt find the next-release branch, only 0.18.0.

Important items to consider before making a Pull Request

Please check items PR complies to:

• [x ] All commits in the PR are squashed. More info
• [ x] The PR is made into dedicated next-release branch, not into master branch¹. More info
• [ x] The PR is signed. More info

[Slach]

Thanks a lot for contribution, I wonder how it works before without errors

[adu-bricks]

Thanks a lot for contribution, I wonder how it works before without errors

it does error (albeit silently), there is only a check if err == nill and so if there is one the err is never pushed to the upstream func to report it.

[Slach]

it does error (albeit silently), there is only a check if err == nill and so if there is one the err is never pushed to the upstream func to report it.

but, this numbers is present in our Grafana Dashboard and show 24x7, correcly now

[adu-bricks]

it does error (albeit silently), there is only a check if err == nill and so if there is one the err is never pushed to the upstream func to report it.

but, this numbers is present in our Grafana Dashboard and show 24x7, correcly now

after some investigation, it. look like the new code never worked, this metrics as been broken since 0.17.0, last working docker image for the metrics-exporter that work is the 0.16.1.

28af2b0 is the commit when it started to never get a value other than 0

Looking at the history it look like per default the image for the metrics-exporter is shipped with :latest but this tag was not in sync with the master branch before ?

[Slach]

@adu-bricks thanks a lot for detailed investigation!

[Slach]

@adu-bricks could you check and confirm issue fixed on metrics-exporter 0.18.0 and latest image version?

[adu-bricks]

@adu-bricks could you check and confirm issue fixed on metrics-exporter 0.18.0 and latest image version?

I can confirm pulling the news :latest and :0.18.0 image fixed the metrics issues.

Thanks !