Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added annotations in metadata propagation test #884

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Added annotations in metadata propagation test #884

merged 2 commits into from
Feb 11, 2022

Conversation

zvonand
Copy link
Contributor

@zvonand zvonand commented Feb 11, 2022

Added new test covering #859

@Slach Slach self-requested a review February 11, 2022 10:50
tests/e2e/test_operator.py Outdated Show resolved Hide resolved
tests/e2e/test_operator.py Outdated Show resolved Hide resolved
@Slach Slach merged commit 6fdd3a5 into Altinity:0.18.2 Feb 11, 2022
Copy link
Member

@alex-zaitsev alex-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is incorrect. @Slach, please do not merge tests without my review please

@Slach
Copy link
Collaborator

Slach commented Feb 11, 2022

@alex-zaitsev
Hm, why test is not correct? Test checks annotations excluding \ including propagation and change config for that, what is wrong in this scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants