Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap all form fields of text editor with FormField component #12002

Closed
Tracked by #10763
mlqn opened this issue Jan 11, 2024 · 0 comments · Fixed by #12029
Closed
Tracked by #10763

Wrap all form fields of text editor with FormField component #12002

mlqn opened this issue Jan 11, 2024 · 0 comments · Fixed by #12029
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. status/triage

Comments

@mlqn
Copy link
Contributor

mlqn commented Jan 11, 2024 •
edited
Loading

Description

I suggest wrapping all form fields with the new FormField component to maintain consistent styling for error messages.
The edit button should also remain centered when an error message is displayed.

Steps To Reproduce

The error message TextId kan ikke være tom looks bigger than it should as it is not wrapped with the FormField component.

Screen.Recording.2024-01-11.at.11.27.17.mov
@mlqn mlqn mentioned this issue Jan 11, 2024
Closed
@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage area/text-editor labels Jan 11, 2024
@mlqn mlqn changed the title Wrap all form fields with the new FormField component to maintain consistent styling for error messages Wrap all form fields of text editor with FormField component Jan 11, 2024
@framitdavid framitdavid added the good first issue Issues that are easy to fix for new team members or external contributors label Jan 11, 2024
@lassopicasso lassopicasso self-assigned this Jan 11, 2024
@lassopicasso lassopicasso mentioned this issue Jan 15, 2024
Merged
4 tasks
@lassopicasso lassopicasso linked a pull request Jan 15, 2024 that will close this issue
Text editor/replace legacy text field with form field #12029
Merged
4 tasks
@lassopicasso lassopicasso removed their assignment Jan 16, 2024
@framitdavid framitdavid assigned lassopicasso and ghost and unassigned framitdavid, lassopicasso and ghost Jan 19, 2024
@ErlingHauan ErlingHauan removed the good first issue Issues that are easy to fix for new team members or external contributors label Jan 22, 2024
@lassopicasso lassopicasso removed their assignment Jan 25, 2024
@standeren standeren assigned standeren and unassigned standeren Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. status/triage
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Text editor/replace legacy text field with form field Altinn/altinn-studio
5 participants
@mlqn @framitdavid @standeren @lassopicasso @ErlingHauan