Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorBoundary stopped working after upgrading react-router-dom #13248

Closed
2 tasks done
mlqn opened this issue Jul 29, 2024 · 1 comment · Fixed by #13304
Closed
2 tasks done

ErrorBoundary stopped working after upgrading react-router-dom #13248

mlqn opened this issue Jul 29, 2024 · 1 comment · Fixed by #13304
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. status/triage

Comments

@mlqn
Copy link
Contributor

mlqn commented Jul 29, 2024 •
edited by framitdavid
Loading

Description of the bug

The top-level ErrorBoundary stopped working after upgrading react-router-dom from 6.18.0 to 6.20.0.

A solution could be to use errorElement.

BEFORE AFTER
273153504-9a870d63-ff8e-4b23-b3f7-de6f9d3a742c error-boundary-after

Steps To Reproduce

To display the ErrorBoundary, insert a JavaScript error into the code (e.g. throw new Error('Test'))

Additional Information

No response

Tasks
Beta Give feedback
@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Jul 29, 2024
@mlqn mlqn changed the title ErrorBoundary stopped working after upgrading react-router-dom ErrorBoundary stopped working after upgrading react-router-dom Jul 29, 2024
@mlqn mlqn changed the title ErrorBoundary stopped working after upgrading react-router-dom ErrorBoundary stopped working after upgrading react-router-dom to 6.20.0 Jul 29, 2024
@mlqn mlqn changed the title ErrorBoundary stopped working after upgrading react-router-dom to 6.20.0 ErrorBoundary stopped working after upgrading react-router-dom Jul 29, 2024
@mlqn mlqn self-assigned this Jul 29, 2024
@mlqn mlqn mentioned this issue Jul 29, 2024
Closed
@framitdavid framitdavid assigned framitdavid and unassigned mlqn Aug 6, 2024
@framitdavid framitdavid linked a pull request Aug 6, 2024 that will close this issue
feat(ErrorBoundry): Implemented Route Based Error Boundry #13304
Merged
3 tasks
@framitdavid framitdavid mentioned this issue Aug 6, 2024
Merged
3 tasks
@framitdavid framitdavid removed their assignment Aug 7, 2024
@mlqn mlqn self-assigned this Aug 9, 2024
@mlqn
Copy link
Contributor Author

mlqn commented Aug 9, 2024

Tested OK 💯 Just one comment. The new implementation currently only catches errors from app-development. We should implement it in the other services as well (dashboard, studio-root, app-preview, and resourceadm), but that would mean duplicating the logic. I am currently working on a PR that will make it possible to implement it in one place for all services.

@mlqn mlqn removed their assignment Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. status/triage
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ErrorBoundry): Implemented Route Based Error Boundry Altinn/altinn-studio
2 participants
@mlqn @framitdavid