Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to use the Alert component from Felles Designsystem #1284

Closed
mikaelrss opened this issue Jun 26, 2023 · 0 comments · Fixed by #1289
Closed

Be able to use the Alert component from Felles Designsystem #1284

mikaelrss opened this issue Jun 26, 2023 · 0 comments · Fixed by #1289
Assignees
@mikaelrss
Labels
kind/feature-request New feature or request kind/product-feature Pull requests containing new features

Comments

@mikaelrss
Copy link
Contributor

mikaelrss commented Jun 26, 2023 •
edited
Loading

Description

We want to be able to present information in the Alert-component from @digdir/desgin-system-react.

Proposed technical solution

This needs to be solved with a new component which implements the Alert from @digdir/design-system-react.

The new component should:

  • Have an option for setting severity.
  • Have an option for setting the attribute role="alert" on the component. This is used for cases where alerts appears as a consequence of user input. Screen readers will then be able to relay the text in the alert to its users.
  • Have an optional title attribute
  • Have an optional description attribute
  • Possibly have an option for turning on and off elevated property (adding a box-shadow).

Additional Information

Screenshot of the design we want to implement:
image

The alert-component in the design-system
@mikaelrss mikaelrss added kind/feature-request New feature or request kind/product-feature Pull requests containing new features status/triage labels Jun 26, 2023
@mikaelrss mikaelrss changed the title Be able to use the Alert component from Be able to use the Alert component from @digdir/design-system-react Jun 27, 2023
@mikaelrss mikaelrss changed the title Be able to use the Alert component from @digdir/design-system-react Be able to use the Alert component from Felles Designsystem Jun 27, 2023
@mikaelrss mikaelrss mentioned this issue Jun 27, 2023
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikaelrss mikaelrss

Labels
kind/feature-request New feature or request kind/product-feature Pull requests containing new features
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Alert): add Alert component which uses @digdir/design-system-react Altinn/app-frontend-react
2 participants
@RonnyB71 @mikaelrss