Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft of progressbar #109

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

@quentinderoubaix quentinderoubaix linked an issue Aug 24, 2023 that may be closed by this pull request
@quentinderoubaix quentinderoubaix force-pushed the 84-implement-progressbar-component branch 3 times, most recently from ddb0241 to c5bb9e7 Compare August 24, 2023 17:18
@quentinderoubaix quentinderoubaix force-pushed the 84-implement-progressbar-component branch 3 times, most recently from 5b47022 to ce23fdd Compare September 4, 2023 19:49
core/lib/progressbar.ts Outdated Show resolved Hide resolved
core/lib/progressbar.ts Outdated Show resolved Hide resolved
core/lib/progressbar.ts Outdated Show resolved Hide resolved
core/lib/progressbar.ts Outdated Show resolved Hide resolved
@AmadeusITGroup AmadeusITGroup deleted a comment from codecov bot Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #109 (9bef819) into main (f16fde2) will increase coverage by 0.21%.
Report is 5 commits behind head on main.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   88.31%   88.52%   +0.21%     
==========================================
  Files          52       55       +3     
  Lines        1386     1429      +43     
  Branches      218      224       +6     
==========================================
+ Hits         1224     1265      +41     
- Misses        125      126       +1     
- Partials       37       38       +1     
Flag Coverage Δ
e2e-1 63.32% <85.71%> (+1.07%) ⬆️
e2e-2 39.90% <ø> (+0.24%) ⬆️
e2e-4 65.93% <87.09%> (+0.67%) ⬆️
e2e-5 49.05% <12.90%> (-1.16%) ⬇️
e2e-7 58.03% <11.76%> (-0.99%) ⬇️
e2e-8 56.93% <82.35%> (+1.29%) ⬆️
unit 91.44% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
angular/lib/src/lib/rating/rating.component.ts 95.83% <ø> (ø)
core/lib/config.ts 92.30% <ø> (ø)
core/lib/rating.ts 97.77% <ø> (ø)
...r/lib/src/lib/progressbar/progressbar.component.ts 90.90% <90.90%> (ø)
react/lib/Progressbar.tsx 92.85% <92.85%> (ø)
core/lib/progressbar.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your previous changes @quentinderoubaix !

Some new suggestions here...

core/lib/progressbar.ts Outdated Show resolved Hide resolved
core/lib/progressbar.ts Outdated Show resolved Hide resolved
core/lib/progressbar.spec.ts Outdated Show resolved Hide resolved
core/lib/progressbar.spec.ts Show resolved Hide resolved
core/lib/progressbar.spec.ts Outdated Show resolved Hide resolved
e2e/progressbar/progressbar.e2e-spec.ts Show resolved Hide resolved
@quentinderoubaix quentinderoubaix force-pushed the 84-implement-progressbar-component branch 2 times, most recently from 27f41af to 1525905 Compare September 17, 2023 22:25
Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little changes to do, it should be fine for the rest ;)

page-objects/lib/progressbar.po.ts Outdated Show resolved Hide resolved
react/demo/app/samples/progressbar/Striped.route.tsx Outdated Show resolved Hide resolved
page-objects/lib/progressbar.po.ts Show resolved Hide resolved
@quentinderoubaix quentinderoubaix merged commit f6600cb into AmadeusITGroup:main Sep 19, 2023
13 checks passed
@quentinderoubaix quentinderoubaix deleted the 84-implement-progressbar-component branch November 15, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement progressbar component
2 participants