Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accordion): clean unused code #164

Merged

Conversation

ValentinNelu
Copy link
Contributor

Removed some unused code for the accordion

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #164 (ef93c3f) into main (6321bfa) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   88.65%   88.70%   +0.05%     
==========================================
  Files          55       55              
  Lines        1445     1443       -2     
  Branches      225      225              
==========================================
- Hits         1281     1280       -1     
+ Misses        126      125       -1     
  Partials       38       38              
Flag Coverage Δ
e2e-1 63.60% <ø> (+0.11%) ⬆️
e2e-2 40.59% <ø> (+0.07%) ⬆️
e2e-4 66.14% <ø> (+0.06%) ⬆️
e2e-5 49.60% <ø> (+0.04%) ⬆️
e2e-7 58.43% <ø> (+0.07%) ⬆️
e2e-8 57.46% <ø> (+0.06%) ⬆️
unit 91.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gular/lib/src/lib/accordion/accordion.component.ts 4.16% <ø> (+0.08%) ⬆️
core/lib/accordion.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ValentinNelu
Copy link
Contributor Author

@divdavem thx for the review

@ValentinNelu ValentinNelu merged commit b30e71b into AmadeusITGroup:main Sep 29, 2023
13 checks passed
@ValentinNelu ValentinNelu deleted the fix/remove_useless_code branch June 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants