Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: adapt the iframes height of the samples #17

Closed
fbasso opened this issue Jul 21, 2023 · 2 comments · Fixed by #77
Closed

Demo: adapt the iframes height of the samples #17

fbasso opened this issue Jul 21, 2023 · 2 comments · Fixed by #77
Assignees
@quentinderoubaix
Labels
demo
Milestone
v0.1

Comments

@fbasso
Copy link
Contributor

fbasso commented Jul 21, 2023

The idea is to adapt the height of the iframe each time the inner content change
@fbasso fbasso added the demo label Jul 21, 2023
@fbasso fbasso changed the title Demo: adapt the iframes height Demo: adapt the iframes height of the samples Jul 21, 2023
@quentinderoubaix quentinderoubaix added this to the Public demo website milestone Jul 28, 2023
@quentinderoubaix quentinderoubaix linked a pull request Aug 8, 2023 that will close this issue
feat: resizable iframe + link headers #77
Merged
@quentinderoubaix
Copy link
Contributor

Made a PR that uses a ResizeObserver for dynamic content.
Though it does not work super well with modals, due to the body elements being smaller than the modal backdrop...

@quentinderoubaix quentinderoubaix self-assigned this Sep 6, 2023
@quentinderoubaix
Copy link
Contributor

Closing as ResizeObserver is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quentinderoubaix quentinderoubaix

Labels
demo
Projects
None yet
Milestone
v0.1
2 participants
@fbasso @quentinderoubaix