Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customization of widgets config types #170

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Oct 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #170 (4f250df) into main (02c60e8) will increase coverage by 0.25%.
The diff coverage is 95.31%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   88.85%   89.11%   +0.25%     
==========================================
  Files          58       61       +3     
  Lines        1472     1488      +16     
  Branches      229      232       +3     
==========================================
+ Hits         1308     1326      +18     
  Misses        125      125              
+ Partials       39       37       -2     
Flag Coverage Δ
e2e-1 63.97% <95.00%> (+0.37%) ⬆️
e2e-2 40.65% <75.00%> (+0.50%) ⬆️
e2e-4 66.66% <95.65%> (+0.09%) ⬆️
e2e-5 50.29% <95.65%> (+0.14%) ⬆️
e2e-7 59.36% <71.42%> (+0.33%) ⬆️
e2e-8 58.53% <95.23%> (+0.46%) ⬆️
unit 91.45% <65.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
angular/headless/src/lib/slot.directive.ts 89.65% <ø> (ø)
angular/headless/src/lib/slotDefault.directive.ts 100.00% <ø> (ø)
angular/headless/src/lib/utils.ts 95.83% <100.00%> (+4.40%) ⬆️
react/headless/Slot.tsx 94.11% <ø> (ø)
react/headless/index.ts 100.00% <ø> (ø)
react/headless/utils.ts 97.29% <100.00%> (+1.84%) ⬆️
svelte/headless/index.ts 100.00% <ø> (ø)
svelte/headless/slotTypes.ts 100.00% <100.00%> (ø)
svelte/headless/utils.ts 90.00% <100.00%> (+3.79%) ⬆️
angular/headless/src/lib/config.ts 94.11% <94.11%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem force-pushed the customWidgetConfigTypes branch 3 times, most recently from 7515bdb to 146021a Compare October 3, 2023 08:10
@divdavem divdavem marked this pull request as ready for review October 3, 2023 09:00
import type {ComponentType, SvelteComponent} from 'svelte';
import {getContext, setContext, createEventDispatcher as svelteCreateEventDispatcher} from 'svelte';
import {createEventDispatcher as svelteCreateEventDispatcher} from 'svelte';
import {useSvelteSlot, type SlotContent, type SlotSvelteComponent, type SlotsPresent} from './slotTypes';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import type separate

@divdavem
Copy link
Member Author

divdavem commented Oct 3, 2023

@ExFlo Thank you for your review!

@divdavem divdavem merged commit 88ee262 into AmadeusITGroup:main Oct 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants