Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating UI utility #237

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Floating UI utility #237

merged 1 commit into from
Dec 5, 2023

Conversation

divdavem
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a081136) 79.20% compared to head (10aaaad) 89.50%.

Files Patch % Lines
core/lib/services/floatingUI.ts 93.87% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #237       +/-   ##
===========================================
+ Coverage   79.20%   89.50%   +10.29%     
===========================================
  Files          67       72        +5     
  Lines        1847     2001      +154     
  Branches      316      350       +34     
===========================================
+ Hits         1463     1791      +328     
+ Misses        277      142      -135     
+ Partials      107       68       -39     
Flag Coverage Δ
e2e-1 59.90% <92.40%> (+1.68%) ⬆️
e2e-2 50.10% <ø> (ø)
e2e-4 59.25% <92.40%> (+1.90%) ⬆️
e2e-5 50.03% <13.92%> (-2.08%) ⬇️
e2e-7 56.75% <92.40%> (-0.67%) ⬇️
e2e-8 53.49% <13.92%> (-1.47%) ⬇️
unit 89.18% <40.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem force-pushed the floatingUI branch 5 times, most recently from 4de1fc5 to 259d924 Compare November 24, 2023 17:52
@divdavem divdavem changed the title [WIP] Floating UI utility Floating UI utility Nov 27, 2023
@divdavem divdavem marked this pull request as ready for review November 27, 2023 08:54
@divdavem
Copy link
Member Author

divdavem commented Dec 5, 2023

@ExFlo Thank you for your review!

@divdavem divdavem merged commit 60bbb4a into AmadeusITGroup:main Dec 5, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants