Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: angular budget error when building with coverage instrumentation #250

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

divdavem
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fd0f2e) 78.95% compared to head (dfa56b2) 89.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #250       +/-   ##
===========================================
+ Coverage   78.95%   89.22%   +10.27%     
===========================================
  Files          61       70        +9     
  Lines        1782     1922      +140     
  Branches      308      334       +26     
===========================================
+ Hits         1407     1715      +308     
+ Misses        272      141      -131     
+ Partials      103       66       -37     
Flag Coverage Δ
e2e-1 58.21% <ø> (ø)
e2e-2 50.10% <ø> (ø)
e2e-4 57.35% <ø> (ø)
e2e-5 52.11% <ø> (ø)
e2e-7 57.42% <ø> (?)
e2e-8 54.96% <ø> (?)
unit 92.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@divdavem divdavem marked this pull request as ready for review November 24, 2023 15:47
@divdavem
Copy link
Member Author

@fbasso Thank you for your review!

@divdavem divdavem merged commit a081136 into AmadeusITGroup:main Nov 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants