Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: portal directive should not move element when not needed #270

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

divdavem
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fb89d26) 92.18% compared to head (41a3ed1) 92.19%.
Report is 1 commits behind head on main.

Files Patch % Lines
core/lib/services/portal.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   92.18%   92.19%   +0.01%     
==========================================
  Files          70       70              
  Lines        1931     1934       +3     
  Branches      339      341       +2     
==========================================
+ Hits         1780     1783       +3     
  Misses         87       87              
  Partials       64       64              
Flag Coverage Δ
e2e-1 74.75% <71.42%> (-0.02%) ⬇️
e2e-2 60.90% <0.00%> (-0.14%) ⬇️
e2e-4 74.31% <0.00%> (-0.17%) ⬇️
e2e-5 69.62% <0.00%> (-0.16%) ⬇️
e2e-7 63.61% <71.42%> (+<0.01%) ⬆️
e2e-8 70.58% <71.42%> (-0.01%) ⬇️
unit 92.49% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem marked this pull request as ready for review November 29, 2023 18:42
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@divdavem
Copy link
Member Author

@quentinderoubaix Thank you for your review!

@divdavem divdavem merged commit a684409 into AmadeusITGroup:main Nov 30, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants