feat: removing dispatch-style events in Svelte #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 92.17% 92.18%
=======================================
Files 70 70
Lines 1943 1932 -11
Branches 343 341 -2
=======================================
- Hits 1791 1781 -10
Misses 87 87
+ Partials 65 64 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
divdavem
force-pushed
the
removeSvelteDispatchEvent
branch
from
5fce1bd
to
c894908
Compare
divdavem
force-pushed
the
removeSvelteDispatchEvent
branch
from
c894908
to
53d8404
Compare
createEventDispatcher is deprecated in Svelte 5, it is now recommended to
use simple props. This commit removes support for on:something={...} events
in AgnosUI components (in favor of only onSomething={...} as in React).
This simplifies a lot the code.
divdavem
force-pushed
the
removeSvelteDispatchEvent
branch
from
53d8404
to
46e6b42
Compare
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createEventDispatcheris deprecated in Svelte 5, it is now recommended to use simple props.Following #225, this PR completely removes support for on:something={...} events in AgnosUI components (in favor of only onSomething={...} as in React). This simplifies a lot the code.