Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing e2e tests #287

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: fixing e2e tests #287

merged 1 commit into from
Dec 5, 2023

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Dec 5, 2023

Commit 60bbb4a was integrated without
rebase and tests failed because they were not adapted after the change in
570275b.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7645f10) 91.90% compared to head (2e1f888) 92.07%.
Report is 1 commits behind head on main.

Files Patch % Lines
core/lib/services/floatingUI.ts 93.87% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   91.90%   92.07%   +0.16%     
==========================================
  Files          70       72       +2     
  Lines        2002     2081      +79     
  Branches      350      366      +16     
==========================================
+ Hits         1840     1916      +76     
- Misses        100      101       +1     
- Partials       62       64       +2     
Flag Coverage Δ
e2e-1 73.86% <92.40%> (+0.91%) ⬆️
e2e-2 62.80% <88.60%> (+1.41%) ⬆️
e2e-4 73.24% <92.40%> (+1.04%) ⬆️
e2e-5 70.42% <86.07%> (+0.50%) ⬆️
e2e-7 60.78% <92.40%> (-0.81%) ⬇️
e2e-8 71.15% <86.07%> (+2.07%) ⬆️
unit 86.58% <40.50%> (-2.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Commit 60bbb4a was integrated without
rebase and tests failed because they were not adapted after the change in
570275b.
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the fix !

@divdavem
Copy link
Member Author

divdavem commented Dec 5, 2023

@quentinderoubaix Thank you for your review!

@divdavem divdavem merged commit ec0d9b5 into AmadeusITGroup:main Dec 5, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants