Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generation of exports on windows #319

Merged

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd05f23) 91.83% compared to head (d4424c1) 91.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          81       81           
  Lines        2083     2083           
  Branches      369      369           
=======================================
  Hits         1913     1913           
  Misses        100      100           
  Partials       70       70           
Flag Coverage Δ
e2e-1 61.68% <ø> (ø)
e2e-2 57.89% <ø> (ø)
e2e-4 69.51% <ø> (-6.67%) ⬇️
e2e-5 79.21% <ø> (ø)
e2e-7 55.17% <ø> (ø)
e2e-8 77.11% <ø> (ø)
unit 90.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem
Copy link
Member

Should we have a build also on a Windows machine in GitHub CI?

@fbasso fbasso self-requested a review December 14, 2023 13:09
Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@fbasso fbasso merged commit 00d8e12 into AmadeusITGroup:main Dec 14, 2023
13 checks passed
@quentinderoubaix quentinderoubaix deleted the fix-generation-exports-windows branch January 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants