-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup wireit #353
feat: setup wireit #353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 92.22% 91.18% -1.05%
==========================================
Files 95 95
Lines 2109 2109
Branches 384 384
==========================================
- Hits 1945 1923 -22
- Misses 93 109 +16
- Partials 71 77 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bbf276f
to
ef444a5
Compare
fa23a17
to
86fe5f1
Compare
Thank you for this PR. wireit looks very interesting. Also, this build worries me a bit because it failed, and re-running it succeeded. Did you investigate why? Is there any race condition when wireit runs? Does wireit run things in parallel and in some scenario, could it lead to some errors? I find this strange. |
b2ed583
to
650f1a7
Compare
thx for your initial review @divdavem ! I have updated the PR to wire wireit everywhere that seemed interesting. What do you think ? |
650f1a7
to
8624041
Compare
8624041
to
3a60aad
Compare
8e8b072
to
11927a6
Compare
11927a6
to
b0dadcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I think it can finally be merged now.
thx for your review @divdavem ! |
No description provided.