Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #33 color contrast in demo website #37

Conversation

quentinderoubaix
Copy link
Contributor

Enable the color contrast rule in the e2e accessibility tests.
Also added an onload function to change the iframe heights after the sample is loaded.

@quentinderoubaix quentinderoubaix linked an issue Jul 30, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #37 (79192dd) into main (4045c82) will decrease coverage by 1.83%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 79192dd differs from pull request most recent head c1eda5f. Consider uploading reports for the commit c1eda5f to get more accurate results

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   85.32%   83.49%   -1.83%     
==========================================
  Files          60       60              
  Lines        1785     1818      +33     
  Branches      359      362       +3     
==========================================
- Hits         1523     1518       -5     
- Misses        211      251      +40     
+ Partials       51       49       -2     
Flag Coverage Δ
e2e-1 70.57% <ø> (ø)
e2e-10 77.11% <ø> (ø)
e2e-2 81.91% <ø> (?)
e2e-3 81.91% <ø> (ø)
e2e-4 52.33% <ø> (-0.41%) ⬇️
e2e-5 80.41% <ø> (ø)
e2e-6 80.41% <ø> (ø)
e2e-7 73.23% <ø> (ø)
e2e-8 77.01% <ø> (ø)
e2e-9 66.18% <ø> (ø)
unit 93.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@divdavem divdavem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for your PR!

demo/src/lib/layout/Sample.svelte Outdated Show resolved Hide resolved
@quentinderoubaix quentinderoubaix force-pushed the 33-fix-color-contrast-in-demo-website branch from 79192dd to c1eda5f Compare July 31, 2023 09:32
@quentinderoubaix quentinderoubaix merged commit e419c85 into AmadeusITGroup:main Jul 31, 2023
11 checks passed
@quentinderoubaix quentinderoubaix deleted the 33-fix-color-contrast-in-demo-website branch July 31, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix color contrast in demo website
2 participants