Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): enforce jsdoc of widgets + exported functions in core closes #30 #52

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

@quentinderoubaix quentinderoubaix linked an issue Aug 2, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #52 (bbc02b2) into main (0f2d891) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head bbc02b2 differs from pull request most recent head 71bcf2c. Consider uploading reports for the commit 71bcf2c to get more accurate results

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   95.98%   96.17%   +0.19%     
==========================================
  Files          62       62              
  Lines        4207     4419     +212     
  Branches      409      409              
==========================================
+ Hits         4038     4250     +212     
  Misses        122      122              
  Partials       47       47              
Flag Coverage Δ
e2e-1 76.66% <ø> (ø)
e2e-2 20.71% <ø> (ø)
e2e-4 79.36% <ø> (ø)
e2e-5 50.26% <ø> (ø)
e2e-7 71.08% <ø> (ø)
e2e-8 34.93% <ø> (ø)
unit 98.76% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
angular/lib/src/lib/select/select.component.ts 100.00% <ø> (ø)
core/lib/alert.ts 98.95% <100.00%> (+0.08%) ⬆️
core/lib/config.ts 100.00% <100.00%> (ø)
core/lib/modal/modal.ts 98.86% <100.00%> (+<0.01%) ⬆️
core/lib/pagination.ts 100.00% <100.00%> (ø)
core/lib/pagination.utils.ts 100.00% <100.00%> (ø)
core/lib/rating.ts 100.00% <100.00%> (ø)
core/lib/select.ts 97.52% <100.00%> (+0.19%) ⬆️
core/lib/services/checks.ts 100.00% <100.00%> (ø)
core/lib/services/focustrack.ts 95.65% <100.00%> (+0.26%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@quentinderoubaix quentinderoubaix force-pushed the 30-enforce-proper-documentation-of-core-components branch 2 times, most recently from 689b5fd to 8a59c05 Compare August 4, 2023 07:05
core/package.json Outdated Show resolved Hide resolved
core/.eslintrc.json Outdated Show resolved Hide resolved
core/lib/rating.ts Outdated Show resolved Hide resolved
core/lib/types.ts Outdated Show resolved Hide resolved
@quentinderoubaix quentinderoubaix force-pushed the 30-enforce-proper-documentation-of-core-components branch from 8a59c05 to bbc02b2 Compare August 4, 2023 15:36
@quentinderoubaix quentinderoubaix force-pushed the 30-enforce-proper-documentation-of-core-components branch from bbc02b2 to 71bcf2c Compare August 4, 2023 15:37
@quentinderoubaix quentinderoubaix merged commit f922011 into AmadeusITGroup:main Aug 4, 2023
13 checks passed
@quentinderoubaix quentinderoubaix deleted the 30-enforce-proper-documentation-of-core-components branch August 4, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce proper documentation of core components
2 participants