Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update parking_lot's dependency on parking_lot_core #332

Open
peterthejohnston opened this issue Mar 21, 2022 · 7 comments
Open

How to update parking_lot's dependency on parking_lot_core #332

peterthejohnston opened this issue Mar 21, 2022 · 7 comments

Comments

@peterthejohnston
Copy link
Contributor

parking_lot_core's dependency on windows-sys was recently updated from v0.33.0 to v0.34.0. What's the process for updating parking_lot's dependency on parking_lot_core? I suppose it would require tagging a new release of the latter, and then updating the root crate to depend on the new release of core?

Am I understanding this change, for example, correctly that it does those things simultaneously?

@a1phyr
Copy link
Contributor

a1phyr commented Mar 25, 2022

There is no need for a release of parking_lot, a minor release of parking_lot_core is enough, as the last one.

@peterthejohnston
Copy link
Contributor Author

peterthejohnston commented Mar 25, 2022

But parking_lot depends specifically on parking_lot_core = "0.9.0", so a new minor release of core wouldn't result in its being pulled into parking_lot.

So I think if I want parking_lot to transitively depend on the latest windows-sys, both parking_lot_core and parking_lot have to be released.

@CryZe
Copy link
Contributor

CryZe commented Mar 25, 2022

That is not the case. 0.9.0 is semver compatible with 0.9.1, so just releasing parking_lot_core 0.9.1 would be enough.

@peterthejohnston
Copy link
Contributor Author

I know that it's semver compatible, but I guess what I'm getting at is that if I were to cargo vendor parking_lot, I'm pretty sure it would pull in parking_lot_core 0.9.0 since it is explicitly pinned to that version, rather than "0.9" for example. Am I missing something?

@bjorn3
Copy link
Contributor

bjorn3 commented Mar 25, 2022

parking_lot is not pinned to 0.9.0. It is pinned to any version semver compatible to 0.9.0, which includes 0.9.1:

parking_lot_core = { path = "core", version = "0.9.0" }

@peterthejohnston
Copy link
Contributor Author

Gotcha, I didn't realize that specifying a full version worked that way. Thanks for clarifying.

@peterthejohnston
Copy link
Contributor Author

This should do it: #334

Although a maintainer would need to publish the new release to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants