Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACE-specific assert implementation #204

Open
tehKaiN opened this issue Aug 24, 2023 · 1 comment · May be fixed by #216
Open

Add ACE-specific assert implementation #204

tehKaiN opened this issue Aug 24, 2023 · 1 comment · May be fixed by #216
Labels
Easy Good starting point if you want to help enhancement
Milestone
TBD before C++ ex...

Comments

@tehKaiN
Copy link
Member

tehKaiN commented Aug 24, 2023 •
edited
Loading

  • replace checkNull() with assert() (aceAssert()?)
  • follow static_assert() syntax with 2nd parameter allowing for error message
    • nice to have: treat 2nd parameter as format string and remaining ones as va_args for logWrite()
  • should use logWrite() and then hang in infinite loop
  • in release builds, asserts should do nothing
    • perhaps add a compile option to make them work in release builds with systemKill() prints to console?
@tehKaiN tehKaiN added enhancement Easy Good starting point if you want to help labels Aug 24, 2023
@tehKaiN tehKaiN added this to the TBD before C++ experiments milestone Oct 29, 2023
@tehKaiN
Copy link
Member Author

tehKaiN commented Nov 26, 2023 •
edited
Loading

I also think that assert calls could change into GCC assume attribute on release or other non-assert builds

https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html

@tehKaiN tehKaiN linked a pull request Dec 7, 2023 that will close this issue
Open
6 tasks
@github-project-automation github-project-automation bot moved this to Todo asap in Management Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Good starting point if you want to help enhancement
Projects
Management
Status: Todo asap
Milestone
TBD before C++ experiments
Development

Successfully merging a pull request may close this issue.

add assume.c/.h, convert assert-like error checks into assume statements AmigaPorts/ACE
1 participant
@tehKaiN