Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed in Magento 1.9.3.1 #9

Closed
sprankhub opened this issue Jan 17, 2017 · 5 comments
Closed

Fixed in Magento 1.9.3.1 #9

sprankhub opened this issue Jan 17, 2017 · 5 comments
Assignees

Comments

@sprankhub
Copy link

Thanks for all your work!

You may want to add that this issue is fixed in Magento 1.9.3.1. See https://github.com/OpenMage/magento-mirror/blob/magento-1.9/app/code/core/Mage/Core/Model/Config.php#L260

@convenient
Copy link
Contributor

convenient commented Jan 17, 2017

Amazing news, thank you @sprankhub!

I'll make sure to update the main README.md soon, it's great to know that Magento has finally added this work to the core.

Now, If only they provided accreditation like they do for security patches. I mean, a website being down is no big deal right ¯\(ツ)

@sprankhub
Copy link
Author

What is that accreditation!? ¯\(ツ)

@convenient
Copy link
Contributor

You get $$$ for security patches and listed as "Reporter" on the patch breakdown. Kudos basically.

I know Magento read this article because I could see them in the referrers, but it would be nice for them to acknowledge that they took this work from here and included it in the core.

Oh well, I must try not to be bitter!

@convenient convenient self-assigned this Jan 17, 2017
@convenient
Copy link
Contributor

Thanks for the info, I've updated the main readme.md.

https://github.com/AmpersandHQ/magento-ce-ee-config-corruption-bug#update-3-baked-into-the-core

@sajidunnar
Copy link

@convenient Luke Thanks for such awesome fix, we are having a similar issue, sometimes our cart page body comes as white/ black but with correct footer and header.

I applied your patches but I think you may share some insight or give more idea to debug this further ?

Can you share your last Config.php with the changes you mentioned in Improvement section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants