Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI remove dbHost, dbName, dbUser and dbPass configuration options #1070

Closed
3 tasks done
Michiel-s opened this issue Apr 13, 2020 · 1 comment
Closed
3 tasks done
Assignees

Comments

@Michiel-s
Copy link
Member

Michiel-s commented Apr 13, 2020

Currently mysql database configuration options can be provided via the command line interface.
This is used by:

  • PHP.hs for travis check
  • Settings.json input file for prototype framework

However, for the prototype framework we're planning to ignore these from the settings.json because database settings are most of the time deployment environment specific. For a local test env you use different settings than for a remote production environement.
As docker is used to build an ampersand prototype image, this image must be different for test and production, because the settings are 'baked' into the image. This is not complying to the "Image Immutability Principle" of container based application design.
See: https://kubernetes.io/blog/2018/03/principles-of-container-app-design/

This issue request removal of the database settings from the Ampersand compiler.

TODOs:

@Michiel-s
Copy link
Member Author

Done after merging #1121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants