Feature/upgrade pandoc #1066
Merged
Feature/upgrade pandoc #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to pandoc 2.9 is a pretty hefty change. Pandoc types have been upgraded to use Text all over the place. Also, Pandoc has done some pretty nice things with its template system.
On the go, I also made some useful changes in the module
String.hs, getting rid of a generic function about escaping character strings. Text does encoding by its own, we do not have to deal with that ourselves any more.I have done a thourough comparison between the generated code with the current development branch and the code in this feature branch, which makes me confident. @Michiel-s, could you please test some of your prototypes with this branch?