Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #932 #934

Merged
merged 2 commits into from
Apr 20, 2019
Merged

fix #932 #934

merged 2 commits into from
Apr 20, 2019

Conversation

hanjoosten
Copy link
Member

--daemon[=configfile]

@hanjoosten hanjoosten self-assigned this Apr 19, 2019
@hanjoosten hanjoosten requested a review from RieksJ April 19, 2019 12:32
@hanjoosten hanjoosten assigned RieksJ and unassigned hanjoosten Apr 19, 2019
@hanjoosten
Copy link
Member Author

@RieksJ , I have added some extra diagnosis stuff for when an error occurs like the one in issue #933. Merge this pull request and build the development branch. Then you will see what is wrong.

RieksJ
RieksJ approved these changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@RieksJ RieksJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #932.

The diagnostic message that was added in support of #933 is not wrong, but it does not provide any useful help either. This is not blocking for the merge though.

@RieksJ RieksJ merged commit 833db37 into development Apr 20, 2019
@RieksJ RieksJ deleted the feature/issue932 branch April 29, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RieksJ RieksJ RieksJ approved these changes

Assignees

@RieksJ RieksJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanjoosten @RieksJ